Fix errors with -Config when plugin has no question prompts or indentation #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add question prompt for $ExcludeVMs for EVC Mismatch
Add question prompt for $ExcludeDS
Fix line-by-line processing of plugins to prevent errors and handle missing question prompts
Reviewer's Guide by SourceryThis pull request addresses errors related to configuration handling when plugins have no question prompts or indentation issues. The main changes include fixing pattern matching in the Get-ID-String function, initializing variables properly, handling cases with no question prompts, and ensuring correct parsing and appending of settings. Additionally, comments were added to plugin files to clarify the purpose of specific settings. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Hossy - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
|
Example for indentation is 04 Map disk region event.ps1 where settings are indented inside an if block. Invoke-Settings will now respect and maintain that indentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
This pull request addresses errors in the vCheck.ps1 script related to handling plugins without question prompts and proper indentation. It also includes enhancements to the settings processing logic and updates to documentation comments in specific plugin scripts.